Determine Content-Type during compilation #594
Conversation
| @@ -91,6 +91,9 @@ pub trait Template { | |||
|
|
|||
| /// Provides a conservative estimate of the expanded length of the rendered template | |||
| const SIZE_HINT: usize; | |||
|
|
|||
| /// The MIME type (Content-Type) of the data that gets rendered by this Template | |||
| const MIME_TYPE: &'static str; | |||
There was a problem hiding this comment.
Should we deprecate EXTENSION and extension()? I feel like this is probably better.
askama_actix/Cargo.toml
Outdated
| @@ -14,7 +14,7 @@ edition = "2018" | |||
|
|
|||
| [dependencies] | |||
| actix-web = { version = "4.0.0-beta.19", default-features = false } | |||
| askama = { version = "0.11.0", path = "../askama", default-features = false, features = ["with-actix-web", "mime", "mime_guess"] } | |||
| askama = { version = "0.11.0", path = "../askama", default-features = false, features = ["with-actix-web"] } | |||
There was a problem hiding this comment.
So I guess semver-compat means we should keep it here, as well.
Kijewski
changed the title
|
I refactored the PR. The last commit "Remove ext argument in integrations" is probably a breaking change according to semver. I'm not sure if the functions in the integration crates (e.g. askama_axum::into_response) can be considered to be part of the public interface, they have no documentation after all. |
askama_shared/src/input.rs
Outdated
| const TEXT_TYPES: [(mime::Mime, mime::Mime); 6] = [ | ||
| (mime::TEXT_PLAIN, mime::TEXT_PLAIN_UTF_8), | ||
| (mime::TEXT_HTML, mime::TEXT_HTML_UTF_8), | ||
| (mime::TEXT_CSS, mime::TEXT_CSS_UTF_8), | ||
| (mime::TEXT_CSV, mime::TEXT_CSV_UTF_8), | ||
| ( | ||
| mime::TEXT_TAB_SEPARATED_VALUES, | ||
| mime::TEXT_TAB_SEPARATED_VALUES_UTF_8, | ||
| ), | ||
| ( | ||
| mime::APPLICATION_JAVASCRIPT, | ||
| mime::APPLICATION_JAVASCRIPT_UTF_8, | ||
| ), | ||
| ]; |
There was a problem hiding this comment.
I'd prefer to outline the const here, just dump it near the bottom of the module (or in the crate root?). Also, could there be a separate commit that moves the logic from askama::mime into askama_shared, forwarding the methods from the old place such that we don't duplicate the logic, and also a separate commit that changes the logic to what you have here?
No problem!
I omitted the diff to remove the "ext" parameters. Maybe we can cherry-pick https://github.com/djc/askama/pull/594/commits/d796abdfbb35b9100d2cbced452a4e38109f310a before the next big release? |
Sounds good. Or even file it as a draft PR including something about compatibility in the title? |
|
Awesome work, thanks! |
Closes #592.